Add logical and op #13342

cccclai · 2025-08-12T21:40:32Z

Summary:
As title, add the logical and op for an internal model

Rollback Plan:

Differential Revision: D80122607

pytorch-bot · 2025-08-12T21:40:35Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13342

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending, 1 Unrelated Failure

As of commit 002e655 with merge base f7df6b1 ():

NEW FAILURE - The following job has failed:

pull / test-openvino-linux / linux-job (gh)
/pytorch/executorch/backends/qualcomm/runtime/QnnBackendOptions.cpp:28:20: error: no match for ‘operator=’ (operand types are ‘executorch::runtime::BackendOption’ and ‘<brace-enclosed initializer list>’)

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-moshi-linux / linux-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-08-12T21:40:45Z

This pull request was exported from Phabricator. Differential Revision: D80122607

github-actions · 2025-08-12T21:41:15Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-08-12T21:46:22Z

This pull request was exported from Phabricator. Differential Revision: D80122607

backends/qualcomm/builders/qnn_constants.py

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-08-13T17:34:25Z

This pull request was exported from Phabricator. Differential Revision: D80122607

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-08-14T22:42:08Z

This pull request was exported from Phabricator. Differential Revision: D80122607

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-08-18T18:21:10Z

This pull request was exported from Phabricator. Differential Revision: D80122607

cccclai · 2025-08-21T15:54:07Z

Can I get a review on this PR? @haowhsu-quic @shewu-quic @winskuo-quic @DannyYuyang-quic

backends/qualcomm/tests/test_qnn_delegate.py

backends/qualcomm/builders/op_logical_and.py

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-08-21T18:41:01Z

This pull request was exported from Phabricator. Differential Revision: D80122607

backends/qualcomm/tests/test_qnn_delegate.py

DannyYuyang-quic

Thanks for supporting more ops!!

DannyYuyang-quic · 2025-08-22T10:11:50Z

backends/qualcomm/builders/qnn_constants.py

+@dataclass(init=False, frozen=True)
+class OpElementWiseAnd:
+    op_name: str = "ElementWiseAnd"


Hi @cccclai, since we already have OpElementWiseAnd at line 111, I believe there's no need to add it again. Thanks!!

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-08-22T19:40:14Z

This pull request was exported from Phabricator. Differential Revision: D80122607

haowhsu-quic · 2025-08-25T06:36:33Z

backends/qualcomm/builders/op_logical_and.py

+
+@register_node_visitor
+class And(NodeVisitor):
+    target = ["aten.logical_and.default"]


I wonder if we could extend the target field in builders/op_and.py?

I'm trying to do that, however I found out the logical_and op doesn't have the corresponding q/dq ops when trying module = self.get_qdq_module(module, sample_input), do you know which path I should be updating?

I think you need to extend annotation with new target in quantizer/annotator.py

executorch/backends/qualcomm/quantizer/annotators.py

Line 831 in 1520f9f

@register_annotator([torch.ops.aten.__and__.Tensor])

Is the latest version correct? It seems still missing the q/dq ops

I think it is because the input is bool type so it won't have qdq. Could you try either 1) FP input. 2) When calling get_qdq_module in UT, also set bypass_check=True?

Oops, I believe the reason is because the input is bool (uint8) rather than float.

executorch/backends/qualcomm/quantizer/annotators.py

Line 194 in 1520f9f

if _is_float_tensor(input_act0):

Ah thanks! Yeah it's indeed the reason

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-09-03T01:28:30Z

This pull request was exported from Phabricator. Differential Revision: D80122607

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

facebook-github-bot · 2025-09-11T21:14:46Z

This pull request was exported from Phabricator. Differential Revision: D80122607

Summary: As title, add the logical and op for an internal model Differential Revision: D80122607

facebook-github-bot · 2025-09-12T00:26:55Z

@cccclai has exported this pull request. If you are a Meta employee, you can view the originating diff in D80122607.

cccclai · 2025-09-12T00:27:11Z

I have it fix, does the new version look good now? @shewu-quic @haowhsu-quic @winskuo-quic @DannyYuyang-quic

facebook-github-bot · 2025-09-12T00:27:19Z

@cccclai has exported this pull request. If you are a Meta employee, you can view the originating diff in D80122607.

shewu-quic · 2025-09-12T07:23:24Z

LGTM. Thanks!

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2025

facebook-github-bot added the fb-exported label Aug 12, 2025

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Aug 12, 2025

Add logical and op (pytorch#13342)

84e712a

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

cccclai force-pushed the export-D80122607 branch from 69ec0bb to 84e712a Compare August 12, 2025 21:46

haowhsu-quic reviewed Aug 13, 2025

View reviewed changes

backends/qualcomm/builders/qnn_constants.py Outdated Show resolved Hide resolved

cccclai force-pushed the export-D80122607 branch from 84e712a to 1c4b1e4 Compare August 13, 2025 17:34

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Aug 13, 2025

Add logical and op (pytorch#13342)

1c4b1e4

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Aug 14, 2025

Add logical and op (pytorch#13342)

5fa2334

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

cccclai force-pushed the export-D80122607 branch from 1c4b1e4 to 5fa2334 Compare August 14, 2025 22:41

cccclai requested review from DannyYuyang-quic, haowhsu-quic, shewu-quic and winskuo-quic August 18, 2025 17:20

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Aug 18, 2025

Add logical and op (pytorch#13342)

e442791

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

cccclai force-pushed the export-D80122607 branch from 5fa2334 to e442791 Compare August 18, 2025 18:20

haowhsu-quic reviewed Aug 21, 2025

View reviewed changes

backends/qualcomm/tests/test_qnn_delegate.py Show resolved Hide resolved

haowhsu-quic reviewed Aug 21, 2025

View reviewed changes

backends/qualcomm/builders/op_logical_and.py Outdated Show resolved Hide resolved

cccclai force-pushed the export-D80122607 branch from e442791 to 06e4b08 Compare August 21, 2025 18:40

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Aug 21, 2025

Add logical and op (pytorch#13342)

06e4b08

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

haowhsu-quic reviewed Aug 22, 2025

View reviewed changes

backends/qualcomm/tests/test_qnn_delegate.py Show resolved Hide resolved

DannyYuyang-quic approved these changes Aug 22, 2025

View reviewed changes

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Aug 22, 2025

Add logical and op (pytorch#13342)

23535ff

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

cccclai force-pushed the export-D80122607 branch from 06e4b08 to 23535ff Compare August 22, 2025 19:39

haowhsu-quic reviewed Aug 25, 2025

View reviewed changes

cccclai force-pushed the export-D80122607 branch from 23535ff to 26aac45 Compare September 3, 2025 01:28

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Sep 3, 2025

Add logical and op (pytorch#13342)

26aac45

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

cccclai force-pushed the export-D80122607 branch from 26aac45 to 895c92a Compare September 11, 2025 21:14

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Sep 11, 2025

Add logical and op (pytorch#13342)

895c92a

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

Add logical and op (pytorch#13342)

002e655

Summary: As title, add the logical and op for an internal model Differential Revision: D80122607

cccclai force-pushed the export-D80122607 branch from 895c92a to 873609d Compare September 12, 2025 00:26

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Sep 12, 2025

Add logical and op (pytorch#13342)

873609d

Summary: As title, add the logical and op for an internal model Differential Revision: D80122607

facebook-github-bot added the meta-exported label Sep 12, 2025

cccclai force-pushed the export-D80122607 branch from 873609d to 002e655 Compare September 12, 2025 00:26

shewu-quic approved these changes Sep 12, 2025

View reviewed changes

cccclai requested review from kimishpatel, kirklandsign and shoumikhin September 12, 2025 16:38

shoumikhin approved these changes Sep 12, 2025

View reviewed changes

cccclai merged commit e6b9111 into pytorch:main Sep 12, 2025
122 of 125 checks passed

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025

Add logical and op (pytorch#13342)

62ded31

Summary: As title, add the logical and op for an internal model Rollback Plan: Differential Revision: D80122607

Add logical and op #13342

Add logical and op #13342

Uh oh!

Conversation

cccclai commented Aug 12, 2025

Uh oh!

pytorch-bot bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13342

❌ 1 New Failure, 2 Pending, 1 Unrelated Failure

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

github-actions bot commented Aug 12, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

Uh oh!

facebook-github-bot commented Aug 13, 2025

Uh oh!

facebook-github-bot commented Aug 14, 2025

Uh oh!

facebook-github-bot commented Aug 18, 2025

Uh oh!

cccclai commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Aug 21, 2025

Uh oh!

Uh oh!

DannyYuyang-quic left a comment

Choose a reason for hiding this comment

Uh oh!

DannyYuyang-quic Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 22, 2025

Uh oh!

haowhsu-quic Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

cccclai Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

shewu-quic Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cccclai Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

winskuo-quic Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

shewu-quic Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cccclai Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 11, 2025

Uh oh!

facebook-github-bot commented Sep 12, 2025

Uh oh!

cccclai commented Sep 12, 2025

Uh oh!

facebook-github-bot commented Sep 12, 2025

Uh oh!

shewu-quic commented Sep 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

pytorch-bot bot commented Aug 12, 2025 •

edited

Loading

This PR needs a `release notes:` label

shewu-quic Sep 1, 2025 •

edited

Loading

shewu-quic Sep 3, 2025 •

edited

Loading